zipkin-php icon indicating copy to clipboard operation
zipkin-php copied to clipboard

Published 20 hours ago • verified publisher icon openzipkin

Add framework instrumentation

Open jcchavezs opened this issue 7 years ago • 5 comments

We need to provide framework integrations for zipkin. Priority frameworks are:

  1. [x] Symfony
  2. [ ] Laravel
  3. [ ] Silex
  4. [x] Guzzle http client

Ping @felixfbecker @beberlei

jcchavezs avatar Dec 08 '17 18:12 jcchavezs

Imo they should definitely be in a separate repo each. They should be able to get their own independent versioning. Noone uses all these frameworks at the same time, so they also shouldn't have to pull in code for it.

felixfbecker avatar Dec 08 '17 18:12 felixfbecker

Integration with Symfony: https://github.com/jcchavezs/zipkin-instrumentation-symfony

jcchavezs avatar Jan 23 '18 21:01 jcchavezs

For laravel, there are this libraries so far:

  • https://github.com/laravelcloud/lar-trace by @jiangjianyong
  • https://github.com/luoxiaojun1992/laravel-zipkin by @luoxiaojun1992
  • https://github.com/luca-giardina/lara-zipkin by @luca-giardina

jcchavezs avatar Mar 18 '19 09:03 jcchavezs

Is this something to still look into? Laravel seems supported and Silex is quite dead.

There are some modern frameworks around (Symlex, Lumen, Spiral)

Lumen seems to have https://github.com/shlj/php-zipkin-lumen

andrei-dascalu avatar Jul 22 '21 09:07 andrei-dascalu

There is a PR for laravel. It would be really cool if we could add a test to make sure laravel works fine. Would you be up to do that?

jcchavezs avatar Jul 23 '21 15:07 jcchavezs