opentracing-python icon indicating copy to clipboard operation
opentracing-python copied to clipboard

Published 20 hours ago • verified publisher icon opentracing

Rename start_active_span() to start_active_scope().

Open carlosalberto opened this issue 7 years ago • 4 comments

For your consideration ;)

@tedsuo @yurishkuro @palazzem @pglombardo @indrekj

carlosalberto avatar Jun 29 '18 13:06 carlosalberto

To avoid confusion, I would say to don't comment this PR and keep the conversation going in the other PR (https://github.com/opentracing/opentracing-ruby/pull/36). We have already many thoughts there so I guess it's better to ignore the Python PR at the moment.

palazzem avatar Jul 03 '18 09:07 palazzem

Good idea. 👍

tedsuo avatar Jul 05 '18 23:07 tedsuo

Hey all,

FYI: we will be postponing this change, and will release OT 2.0 today/tomorrow (Tuesday, July 10th).

We will iterate and will get proper feedback on the rest of the supported languages, and will deprecate later on as needed (this will also be covered as part of https://github.com/opentracing/specification/pull/122)

Thanks for the feedback @indrekj and hope we can find a proper agreement rather soon ;)

carlosalberto avatar Jul 10 '18 03:07 carlosalberto

This could be actually affected by #107 - if we don't do any changes, then yeah, we could keep this renaming PR/iteration. Thoughts?

carlosalberto avatar Oct 31 '18 14:10 carlosalberto