origin
origin copied to clipboard
openshift
RUN-1933: test unprivileged builds
Test builds where we set BUILD_PRIVILEGED=false in the environment to ask the build controller to ask nodes to run builds with fewer privileges.
Verify that builds run with lower privileges by looking for a diagnostic message that the builder logs at log level 2 or higher when it notices that it's running in a user namespace with ID mappings that aren't the node-level default mappings.
Add unprivileged variations to multiple tests that ensure that we can still pass secrets to the builder, and that it can read them properly.
Revise default-privileged cases that assumed the names of builds that now share a BuildConfig with an unprivileged test, since the tests, and their builds, can happen in unexpected sequence.
Depends on https://github.com/openshift/openshift-controller-manager/pull/173.
Whoops, forgot to mark this as a WIP. /retitle WIP: test unprivileged builds
Test failures seem to have come down to a missing bit of SELinux policy that would allow us to use kernel overlay, and a kernel-side bug that causes an error when we try to fall back to using fuse-overlayfs. Removing the WIP label.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nalind
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval by writing /assign @knobunc in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nalind: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-fips | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | true | /test e2e-aws-fips |
| ci/prow/e2e-aws-single-node-upgrade | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-single-node-upgrade |
| ci/prow/e2e-gcp | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | true | /test e2e-gcp |
| ci/prow/e2e-aws-single-node | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-single-node |
| ci/prow/e2e-aws-cgroupsv2 | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-cgroupsv2 |
| ci/prow/e2e-gcp-builds | 88215b0c49be9d30d38a4f84133076238da2f882 | link | true | /test e2e-gcp-builds |
| ci/prow/e2e-aws-ovn-fips | 88215b0c49be9d30d38a4f84133076238da2f882 | link | true | /test e2e-aws-ovn-fips |
| ci/prow/e2e-aws-ovn-serial | 88215b0c49be9d30d38a4f84133076238da2f882 | link | true | /test e2e-aws-ovn-serial |
| ci/prow/e2e-gcp-ovn | 88215b0c49be9d30d38a4f84133076238da2f882 | link | true | /test e2e-gcp-ovn |
| ci/prow/e2e-aws-ovn-single-node | 88215b0c49be9d30d38a4f84133076238da2f882 | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 88215b0c49be9d30d38a4f84133076238da2f882 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-gcp-ovn-upgrade | 88215b0c49be9d30d38a4f84133076238da2f882 | link | true | /test e2e-gcp-ovn-upgrade |
| ci/prow/e2e-aws-ovn-single-node-serial | 88215b0c49be9d30d38a4f84133076238da2f882 | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-aws-ovn-cgroupsv2 | 88215b0c49be9d30d38a4f84133076238da2f882 | link | false | /test e2e-aws-ovn-cgroupsv2 |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 88215b0c49be9d30d38a4f84133076238da2f882 | link | false | /test e2e-metal-ipi-ovn-ipv6 |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nalind
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval by writing /assign @bparees in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@nalind: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-fips | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | true | /test e2e-aws-fips |
| ci/prow/e2e-aws-single-node-upgrade | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-single-node-upgrade |
| ci/prow/e2e-gcp | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | true | /test e2e-gcp |
| ci/prow/e2e-aws-single-node | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-single-node |
| ci/prow/e2e-aws-cgroupsv2 | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-cgroupsv2 |
| ci/prow/e2e-gcp-builds | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-gcp-builds |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-aws-ovn-single-node-upgrade | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-aws-ovn-single-node-serial | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-agnostic-ovn-cmd | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-agnostic-ovn-cmd |
| ci/prow/e2e-aws-ovn-fips | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-aws-ovn-fips |
| ci/prow/e2e-aws-ovn-single-node | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-aws-ovn-cgroupsv2 | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-aws-ovn-cgroupsv2 |
| ci/prow/e2e-gcp-ovn-rt-upgrade | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | false | /test e2e-gcp-ovn-rt-upgrade |
| ci/prow/e2e-gcp-ovn | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-gcp-ovn |
| ci/prow/e2e-gcp-ovn-builds | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-gcp-ovn-builds |
| ci/prow/e2e-gcp-ovn-image-ecosystem | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-gcp-ovn-image-ecosystem |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nalind Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Need to weed out some errors connecting to registries, which were hopefully transient problems. /retest
@nalind: This pull request references RUN-1933 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.
In response to this:
Test builds where we set BUILD_PRIVILEGED=false in the environment to ask the build controller to ask nodes to run builds with fewer privileges.
Verify that builds run with lower privileges by looking for a diagnostic message that the builder logs at log level 2 or higher when it notices that it's running in a user namespace with ID mappings that aren't the node-level default mappings.
Add unprivileged variations to multiple tests that ensure that we can still pass secrets to the builder, and that it can read them properly.
Revise default-privileged cases that assumed the names of builds that now share a BuildConfig with an unprivileged test, since the tests, and their builds, can happen in unexpected sequence.
Depends on https://github.com/openshift/openshift-controller-manager/pull/173.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@nalind: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-fips | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | true | /test e2e-aws-fips |
| ci/prow/e2e-aws-single-node-upgrade | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-single-node-upgrade |
| ci/prow/e2e-gcp | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | true | /test e2e-gcp |
| ci/prow/e2e-aws-single-node | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-single-node |
| ci/prow/e2e-aws-cgroupsv2 | 49f289280e14b1d6b1af7a8c9cba05e34f692c39 | link | false | /test e2e-aws-cgroupsv2 |
| ci/prow/e2e-gcp-builds | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-gcp-builds |
| ci/prow/e2e-gcp-ovn-image-ecosystem | e2878c4ad5e0de7302ac0dcc4e3202ae4aa09566 | link | true | /test e2e-gcp-ovn-image-ecosystem |
| ci/prow/e2e-azure-ovn-etcd-scaling | d20b2361fb14560765938248d71b83cee814b1d6 | link | false | /test e2e-azure-ovn-etcd-scaling |
| ci/prow/e2e-vsphere-ovn-etcd-scaling | d20b2361fb14560765938248d71b83cee814b1d6 | link | false | /test e2e-vsphere-ovn-etcd-scaling |
| ci/prow/e2e-aws-ovn-etcd-scaling | d20b2361fb14560765938248d71b83cee814b1d6 | link | false | /test e2e-aws-ovn-etcd-scaling |
| ci/prow/e2e-gcp-ovn-etcd-scaling | d20b2361fb14560765938248d71b83cee814b1d6 | link | false | /test e2e-gcp-ovn-etcd-scaling |
| ci/prow/e2e-openstack-ovn | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-openstack-ovn |
| ci/prow/e2e-agnostic-ovn-cmd | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-agnostic-ovn-cmd |
| ci/prow/e2e-gcp-csi | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-gcp-csi |
| ci/prow/e2e-gcp-ovn-upgrade | 5be597dea306d0324edbb4755855651efd8651aa | link | true | /test e2e-gcp-ovn-upgrade |
| ci/prow/e2e-gcp-ovn-rt-upgrade | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-gcp-ovn-rt-upgrade |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 5be597dea306d0324edbb4755855651efd8651aa | link | true | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-aws-ovn-upgrade | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-aws-ovn-upgrade |
| ci/prow/e2e-aws-csi | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-aws-csi |
| ci/prow/e2e-aws-ovn-serial | 5be597dea306d0324edbb4755855651efd8651aa | link | true | /test e2e-aws-ovn-serial |
| ci/prow/e2e-aws-ovn-cgroupsv2 | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-aws-ovn-cgroupsv2 |
| ci/prow/e2e-gcp-ovn-builds | 5be597dea306d0324edbb4755855651efd8651aa | link | true | /test e2e-gcp-ovn-builds |
| ci/prow/e2e-metal-ipi-sdn | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-metal-ipi-sdn |
| ci/prow/e2e-aws-ovn-single-node | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-gcp-ovn | 5be597dea306d0324edbb4755855651efd8651aa | link | true | /test e2e-gcp-ovn |
| ci/prow/e2e-aws-ovn-single-node-serial | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 5be597dea306d0324edbb4755855651efd8651aa | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-aws-ovn-fips | 5be597dea306d0324edbb4755855651efd8651aa | link | true | /test e2e-aws-ovn-fips |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale