ci-tools

ci-tools copied to clipboard

While Prow does auto-request review from folks in OWNERS, it's common for these automatic review requests to go primarily to root OWNERS, leading to a situation where the original code in the pr-reminder would send a very long private message to one or two people who are already swamped and can't do much about it.

This commit adds new functionality that lets teams put a channel into their config where brand-new PRs that need eyeballs can be highlighted. Once someone is assigned to the PR, these will no longer be part of the "new" pool.

 === FAIL: pkg/steps TestRPMServerStepProvides (0.00s)
==================
WARNING: DATA RACE
Write at 0x00c000568120 by goroutine 4343:
  runtime.mapassign()
      /usr/local/go/src/runtime/map.go:579 +0x0
  k8s.io/apimachinery/pkg/runtime.(*Scheme).AddUnversionedTypes()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/runtime/scheme.go:128 +0x5cb
  k8s.io/apimachinery/pkg/apis/meta/v1.AddToGroupVersion()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/register.go:75 +0x5ea
  github.com/openshift/api/route/v1.addKnownTypes()
      /go/src/github.com/openshift/ci-tools/vendor/github.com/openshift/api/route/v1/register.go:37 +0x18a
  k8s.io/apimachinery/pkg/runtime.(*SchemeBuilder).AddToScheme()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/runtime/scheme_builder.go:29 +0xa1
  k8s.io/apimachinery/pkg/runtime.(*SchemeBuilder).AddToScheme-fm()
      <autogenerated>:1 +0x1f
  github.com/openshift/ci-tools/pkg/steps.TestRPMServerStepProvides()
      /go/src/github.com/openshift/ci-tools/pkg/steps/rpm_server_test.go:23 +0x6c
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1595 +0x238
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1648 +0x44
Previous read at 0x00c000568120 by goroutine 3887:
  runtime.mapaccess2()
      /usr/local/go/src/runtime/map.go:457 +0x0
  k8s.io/apimachinery/pkg/runtime.(*Scheme).ObjectKinds()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/runtime/scheme.go:267 +0x2fe
  k8s.io/apimachinery/pkg/runtime/serializer/json.(*Serializer).Decode()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/runtime/serializer/json/json.go:163 +0x51e
  k8s.io/apimachinery/pkg/runtime/serializer/recognizer.(*decoder).Decode()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/runtime/serializer/recognizer/recognizer.go:102 +0x3d6
  k8s.io/apimachinery/pkg/runtime/serializer/versioning.(*codec).Decode()
      /go/src/github.com/openshift/ci-tools/vendor/k8s.io/apimachinery/pkg/runtime/serializer/versioning/versioning.go:139 +0x2bb
  sigs.k8s.io/controller-runtime/pkg/client/fake.(*fakeClient).Get()
      /go/src/github.com/openshift/ci-tools/vendor/sigs.k8s.io/controller-runtime/pkg/client/fake/client.go:491 +0x51e
  github.com/openshift/ci-tools/pkg/steps.checkAndReleaseUnusedLeases()
      /go/src/github.com/openshift/ci-tools/pkg/steps/ip_pool.go:157 +0x396
  github.com/openshift/ci-tools/pkg/steps.(*ipPoolStep).run.func1()
      /go/src/github.com/openshift/ci-tools/pkg/steps/ip_pool.go:116 +0x15e
Goroutine 4343 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1648 +0x82a
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:2054 +0x84
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1595 +0x238
  testing.runTests()
      /usr/local/go/src/testing/testing.go:2052 +0x896
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1925 +0xb57
  main.main()
      _testmain.go:155 +0x2e4
Goroutine 3887 (running) created at:
  github.com/openshift/ci-tools/pkg/steps.(*ipPoolStep).run()
      /go/src/github.com/openshift/ci-tools/pkg/steps/ip_pool.go:116 +0xd16
  github.com/openshift/ci-tools/pkg/steps.TestRun.func6()
      /go/src/github.com/openshift/ci-tools/pkg/steps/ip_pool_test.go:321 +0x48f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1595 +0x238
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1648 +0x44
================== 

Failure in unit is an unrelated data race - I hope you all have it recorded somewhere already?

/test e2e /test unit

Updated, thanks!

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [hongkailiu]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/test remaining-required

@stevekuznetsov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	9424fe01780f98f48cea1dd2dce0adaf22a75769	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.