api

api copied to clipboard

• aws
• nutanix
• openstack
• powervs
• vsphere

Have all passed e2e tests using the capi installer.

Depends on https://github.com/openshift/installer/pull/8343 Depends on https://issues.redhat.com/browse/CORS-3477

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

Hello @patrickdillon! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

/test ?

@patrickdillon: The following commands are available to trigger required jobs:

• /test build
• /test e2e-aws-ovn
• /test e2e-aws-ovn-hypershift
• /test e2e-aws-ovn-techpreview
• /test e2e-aws-serial
• /test e2e-aws-serial-techpreview
• /test e2e-upgrade
• /test e2e-upgrade-minor
• /test images
• /test integration
• /test unit
• /test verify
• /test verify-client-go
• /test verify-crd-schema
• /test verify-deps

The following commands are available to trigger optional jobs:

• /test e2e-azure
• /test e2e-gcp
• /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-api-master-build
• pull-ci-openshift-api-master-e2e-aws-ovn
• pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
• pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
• pull-ci-openshift-api-master-e2e-aws-serial
• pull-ci-openshift-api-master-e2e-aws-serial-techpreview
• pull-ci-openshift-api-master-e2e-azure
• pull-ci-openshift-api-master-e2e-gcp
• pull-ci-openshift-api-master-e2e-upgrade
• pull-ci-openshift-api-master-e2e-upgrade-minor
• pull-ci-openshift-api-master-images
• pull-ci-openshift-api-master-integration
• pull-ci-openshift-api-master-unit
• pull-ci-openshift-api-master-verify
• pull-ci-openshift-api-master-verify-client-go
• pull-ci-openshift-api-master-verify-crd-schema
• pull-ci-openshift-api-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test pull-ci-openshift-api-master-e2e-aws-ovn-techpreview

We should see this fail with a message like:

level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to run cluster api system: failed to run local control plane: failed to unpack cluster-api binary: failed to open cluster api zip from mirror: open mirror/cluster-api.zip: file does not exist

These dependencies will be resolved with https://github.com/openshift/installer/pull/8343 (and the corresponding OSBS pr), in which case we can rerun this test and confirm it is working as expected.

@patrickdillon: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

• /test build
• /test e2e-aws-ovn
• /test e2e-aws-ovn-hypershift
• /test e2e-aws-ovn-techpreview
• /test e2e-aws-serial
• /test e2e-aws-serial-techpreview
• /test e2e-upgrade
• /test e2e-upgrade-minor
• /test images
• /test integration
• /test unit
• /test verify
• /test verify-client-go
• /test verify-crd-schema
• /test verify-deps

The following commands are available to trigger optional jobs:

• /test e2e-azure
• /test e2e-gcp
• /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-api-master-build
• pull-ci-openshift-api-master-e2e-aws-ovn
• pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
• pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
• pull-ci-openshift-api-master-e2e-aws-serial
• pull-ci-openshift-api-master-e2e-aws-serial-techpreview
• pull-ci-openshift-api-master-e2e-azure
• pull-ci-openshift-api-master-e2e-gcp
• pull-ci-openshift-api-master-e2e-upgrade
• pull-ci-openshift-api-master-e2e-upgrade-minor
• pull-ci-openshift-api-master-images
• pull-ci-openshift-api-master-integration
• pull-ci-openshift-api-master-unit
• pull-ci-openshift-api-master-verify
• pull-ci-openshift-api-master-verify-client-go
• pull-ci-openshift-api-master-verify-crd-schema
• pull-ci-openshift-api-master-verify-deps

In response to this:

/test pull-ci-openshift-api-master-e2e-aws-ovn-techpreview

We should see this fail with a message like:

level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to run cluster api system: failed to run local control plane: failed to unpack cluster-api binary: failed to open cluster api zip from mirror: open mirror/cluster-api.zip: file does not exist

These dependencies will be resolved with https://github.com/openshift/installer/pull/8343 (and the corresponding OSBS pr), in which case we can rerun this test and confirm it is working as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/hold for https://github.com/openshift/installer/pull/8343

We should see this fail with a message like:

doh, I forgot that we won't see any installer changes until we vendor this, so I will create a corresponding installer pr

/cc @JoelSpeed I will create a pr to the installer vendoring the local version of this pr

Created https://github.com/openshift/installer/pull/8372 vendoring my local copy, and commented with proof of local testing

/hold cancel

Confirmed that the most recent nightly, https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/4.16.0-0.nightly-2024-05-08-222442 can now run the capi installer

@JoelSpeed I think this is ready to move forward, or at least for review

/test all /payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-techpreview

Is it possible to trigger some cluster bot test workflows using this PR for PowerVS, OpenStack and Nutanix to prove we aren't breaking those by promoting these gates?

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0440ffa0-0e17-11ef-9244-a8acec50993b-0

Is it possible to trigger some cluster bot test workflows using this PR for PowerVS, OpenStack and Nutanix to prove we aren't breaking those by promoting these gates?

We can't test effectively only with this PR because it is essentially a no op until the changes are vendored to the installer, but I can try with https://github.com/openshift/installer/pull/8372

I triggered e2e presubmits for nutanix and openstack to see if it breaks normal installs. There are apparently no powervs presubmits.

I can try clusterbot to test if we break techpreview, but on the other hand, there are no existing tests for techpreview on openstack, nutanix or powervs, because my pr to add them was merged just yesterday. So we don't really have a baseline to compare it to.

Clusterbot can only test openstack in techpreview:

Patrick Dillon

1:07 PM launch 4.16,openshift/installer#8372 nutanix,techpreview New

Cluster Bot APP 1:07 PM configuration error, unable to find prow job matching job-architecture=amd64,job-env=nutanix,job-type=launch with parameters=techpreview

Patrick Dillon 1:07 PM launch 4.16,openshift/installer#8372 powervs,techpreview

Cluster Bot APP 1:07 PM unrecognized option: powervs

Glad to see gating be used to good purpose. Targeted at TechPreview (not default), I'm in favor.

/approve

/lgtm /hold

Release whenever you're ready

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, patrickdillon, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/hold cancel

/retest-required

Remaining retests: 0 against base HEAD 02500a65025d188869e259ff8ed2c692e0cd80ea and 2 for PR HEAD d4cff9caf4b363d4b3062d5031aabbc4e4edbd25 in total

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202405100946.p0.g88a8afe.assembly.stream.el9 for distgit ose-cluster-config-api. All builds following this will include this PR.