security-dashboards-plugin icon indicating copy to clipboard operation
security-dashboards-plugin copied to clipboard

Remove MDS selector for tenancy tab

Open derek-ho opened this issue 1 year ago • 1 comments
trafficstars

Description

For MDS, tenancy tab is always locked to local cluster. When disabling/removing local cluster, this causes an edge case where local cluster does not exist in the picker, but is still locked to on the page. This PR removes the picker for the tenancy tab altogether, since tenancy is a dashboards concept and does not really apply in MDS world.

Category

Maintenace

Why these changes are required?

Fix: #1933

What is the old behavior before changes and new behavior after changes?

Issues Resolved

Fix: #1933

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • [x] New functionality includes testing
  • [ ] New functionality has been documented
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho avatar May 03 '24 18:05 derek-ho

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.90%. Comparing base (6425893) to head (67b4946).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
+ Coverage   69.87%   69.90%   +0.02%     
==========================================
  Files          97       97              
  Lines        2503     2502       -1     
  Branches      336      336              
==========================================
  Hits         1749     1749              
+ Misses        673      672       -1     
  Partials       81       81              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 19:05 codecov[bot]