security-dashboards-plugin icon indicating copy to clipboard operation
security-dashboards-plugin copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

Fix issue when using OpenID Authentication with serverBasePath

Open cwperks opened this issue 1 year ago • 1 comments
trafficstars

Description

This PR fixes a bug where the security-dashboards-plugin would redirect back to / instead of /{serverBasePath} after authenticating with OpenID.

This PR also performs all SAML, OpenID and Multi-auth cypress tests both without a basePath and with a basePath

Category

Bug Fix

Issues Resolved

  • https://github.com/opensearch-project/security-dashboards-plugin/issues/1897

Check List

  • [X] New functionality includes testing
  • [X] New functionality has been documented
  • [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks avatar Apr 18 '24 19:04 cwperks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.94%. Comparing base (347f579) to head (bd82997).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1899   +/-   ##
=======================================
  Coverage   69.94%   69.94%           
=======================================
  Files          97       97           
  Lines        2505     2505           
  Branches      336      343    +7     
=======================================
  Hits         1752     1752           
  Misses        672      672           
  Partials       81       81

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 19 '24 21:04 codecov[bot]

@DarshitChanpura Replied to both outstanding comments. I was not able to figure out a way to reduce it to a single step. Can those be addressed in a follow-up PR?

cwperks avatar May 08 '24 12:05 cwperks