ansible-playbook icon indicating copy to clipboard operation
ansible-playbook copied to clipboard

Creating ISM polisies via role

Open ssi444 opened this issue 3 years ago • 12 comments

Description

Added the ability to automatically create ISM policies.

Issues Resolved

https://github.com/opensearch-project/ansible-playbook/issues/66

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ssi444 avatar May 24 '22 13:05 ssi444

Calling @saravanan30erd @prudhvigodithi for the review. Thanks.

ssi444 avatar May 24 '22 13:05 ssi444

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

ssi444 avatar May 31 '22 13:05 ssi444

@saravanan30erd Please let me know if you have bandwidth to review this. @ssi444 Sorry we are focusing on two minor releases in the past weeks that is why this is pretty slow. Thanks.

peterzhuamazon avatar Jun 09 '22 19:06 peterzhuamazon

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

ssi444 avatar Jun 21 '22 13:06 ssi444

@peterzhuamazon @saravanan30erd @prudhvigodithi ping

ssi444 avatar Jun 27 '22 08:06 ssi444

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

prudhvigodithi avatar Mar 22 '23 18:03 prudhvigodithi

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

prudhvigodithi avatar Mar 22 '23 18:03 prudhvigodithi

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

This is one of the important tasks for using this role as an IaC. In production, we most often add ISM and index pattern (PR #68)

ssi444 avatar Mar 22 '23 19:03 ssi444

Thanks @ssi444, @peterzhuamazon please add your thoughts on this PR and index pattern (PR https://github.com/opensearch-project/ansible-playbook/pull/68) Thank you

prudhvigodithi avatar Mar 23 '23 16:03 prudhvigodithi

Thanks @ssi444, @peterzhuamazon please add your thoughts on this PR and index pattern (PR #68) Thank you

Hi all,

We welcome the contribution but it looks like doesn't cater to wider variety of users as it specifically add settings for a plugin or two.

Need more discussion on whether this is addition to the repo, or is just support for user-specific scenario. Let me know what you guys think @bbarani @gaiksaya @rishabh6788 .

Thanks.

peterzhuamazon avatar Mar 23 '23 19:03 peterzhuamazon

If the number of users using this role for regular cluster updates according to the IaC methodology is insignificant, then it may not be worth implementing this PR. We are actively using this in production and I decided to share our best practices with the community. With this role we manage:

  • index pattern
  • ISM
  • installing plugins

There are plans to complete the management of visualizations and dashboards. We don't use them at home, but if the community is interested, then I can make the necessary improvements.

ssi444 avatar Mar 23 '23 20:03 ssi444

Anyone looking in to this PR? @prudhvigodithi @peterzhuamazon @TheAlgo

bbarani avatar Sep 25 '23 18:09 bbarani

Looks like there was no consensus of what to do with this PR. Closing it as stalled, please reopen if you don't agree!

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

dblock avatar Jul 01 '24 16:07 dblock