lua-nginx-module icon indicating copy to clipboard operation
lua-nginx-module copied to clipboard

Published 20 hours ago • verified publisher icon openresty

ngx.location.capture - pass method names

Open aviramc opened this issue 10 years ago • 14 comments

Added the option to pass the method of the subrequests to ngx.location.capture as a string in addition to the integer based value. This is an update (and a cleaner diff) of pull request #289

aviramc avatar Apr 01 '15 15:04 aviramc

And again, we need some test cases for this new feature in our existing test suite :)

Thank you for your hard work!

agentzh avatar Apr 01 '15 19:04 agentzh

@agentzh , made the requested corrections and added test cases

aviramc avatar Apr 09 '15 16:04 aviramc

Is this issue still getting merge?

mingfang avatar Apr 04 '16 06:04 mingfang

@mingfang Yes. Though needs some cleanup and optimizations.

agentzh avatar Apr 06 '16 16:04 agentzh

@agentzh Is this going to get merged? I would also find this feature really useful.

lucky-bai avatar Nov 22 '16 01:11 lucky-bai

This PR needs some coding style fixes and should be rebased to the latest master. It's currently having conflicts with the latest master.

agentzh avatar Nov 22 '16 04:11 agentzh

@agentzh i have rebased to the latest master in #920. And Also do the optimizations which we have talk in the review:)

detailyang avatar Nov 26 '16 15:11 detailyang

This pull request is now in conflict :(

mergify[bot] avatar Oct 24 '21 07:10 mergify[bot]