headers-more-nginx-module

headers-more-nginx-module copied to clipboard

Update: I found this issue mentioned here and requires updates to use new api

I tried to compile the latest Nginx 1.23.0 on Ubuntu 22.04 with my usual build script and it's failing - looks like headers more module issue as follows ngx_http_headers_in_t’ has no member named ‘cookies’; did you mean ‘cookie’?

/usr/local/src/nginx/modules/headers-more-nginx-module-0.33/src/ngx_http_headers_more_util.c In file included from /usr/include/dlfcn.h:24, from src/os/unix/ngx_linux_config.h:58, from src/core/ngx_config.h:26, from /usr/local/src/nginx/modules/headers-more-nginx-module-0.33/src/ddebug.h:5, from /usr/local/src/nginx/modules/headers-more-nginx-module-0.33/src/ngx_http_headers_more_headers_in.c:10: /usr/local/src/nginx/modules/headers-more-nginx-module-0.33/src/ngx_http_headers_more_headers_in.c:162:50: error: ‘ngx_http_headers_in_t’ has no member named ‘cookies’; did you mean ‘cookie’? 162 | offsetof(ngx_http_headers_in_t, cookies), | ^~~~~~~ make[1]: *** [objs/Makefile:1787: objs/addon/src/ngx_http_headers_more_headers_in.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/usr/local/src/nginx/nginx-1.23.0' make: *** [Makefile:10: build] Error 2

I was able to work around this issue by cloning the trunk and not using the 0.33 tag

Is a new tag planned soon with the latest fixes ?

I second the request for the new tag because it's stopping us leading edge enthusiasts from using Nginx 1.23.0 with the latest Tag

For anyone with an issue just change your build scripts to clone the repository rather than download the tag and it will compile just fine with Nginx 1.23.0

I love and rely on headers more module and ask please publish a tag compatible with Nginx 1.23.0

create a tag v0.34

@skid9000

Is a new tag planned soon with the latest fixes ?

https://github.com/openresty/headers-more-nginx-module/releases/tag/v0.34

Thanks !

Thank you all! The nginx core developers shrugged away any responsibility on the mandatory ABI change (https://nginx.org/en/CHANGES) — since nginx 1.23.0, all headers are now returned as a linked list, as opposed to an array.

v0.34 seems to deal with the changes nicely!