web

web copied to clipboard

Basically all the folders / files for the de translations. Also translated 2 files already, the rest is just the english files.

Username Black-Z18XE
Discord: Addy#6585
Language(ISO): de

All committers have signed the CLA.

LGTM!

Dumb question, as i am kinda new to this: Do i have to make a new pull request everytime I edited something, or will the changes be automatically added here for review? Also where would i do this?

@Black-Z18XE No, you don't need a new PR for every change. Only if the change made is not relevant to the current PR, then yes, it is advisable to open another one, but this is not the case here. Also, any changes you make in the branch where the PR was opened will automatically be added to this PR.

Hit me up when the PR is ready to merge. 👍

I guess that will take ages @leonardssh. Maybe its smarter to merge it every now and then, when some parts are completed. For example once im done with the callbacks

idk really

@Black-Z18XE take your time. I'll merge this when everything its done. 👍

Also, I'll convert this PR into a draft, and when everything its done, hit me up and I'll merge it.

Remove the English files from the PR and we can merge it.

Duplicating 600+ pages is not ideal, and will make tracking progress very difficult.

@Southclaws can you tell me how this works, im pretty new to github. Or should i add you to the repository, so you can help me with it ?

Or do you mean, i should remove the english from the de folder? I was going to change them over time. Its easier to change the english file, than uploading every file, once i want to translate it you know. That way the first version of the german pages would also have a fallback to the english. Idk really, maybe im just retarded :)

Im a little confused now, i think at first the structure should be taken from the english and then all files should be translated over time.

Yes the structure must be the exact same as English, but don't literally upload English documents into the German directory for the aforementioned reasons.

You can keep that locally or on a separate branch but in pull requests, it's basically impossible to review or track progress when all 600+ files are in a single pull request and 99% of them are still English content.

Just found some time to remove the english files for you. I guess its now ready for the first merge. @Southclaws

I guess now it should be ready ?

Should be good to merge, just need to delete that random empty file

Thank you for the contribution!