openmrs-esm-core icon indicating copy to clipboard operation
openmrs-esm-core copied to clipboard

Published 20 hours ago • verified publisher icon openmrs

(fix) O3-2489 - toDateObjectStrict returns null if the passed string is not considered a valid date

Open kitaroghope opened this issue 1 year ago • 1 comments

Requirements

  • [x] This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • [ ] My work includes tests or is validated by existing tests.
  • [ ] I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This adds a custom error message to the 'toDateObjectString' when a non-valid date is passed into it as a 'omrsDateString'

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-2489

Other

kitaroghope avatar Mar 31 '24 10:03 kitaroghope

Do not delete the PR template; fill it in. Follow the instructions. I have added the template back in and filled it in for you.

For your code, delete the comment and write some tests.

brandones avatar Apr 19 '24 15:04 brandones

Closing this; author is not addressing feedback.

brandones avatar Jul 03 '24 21:07 brandones

alright

On Thu, 4 Jul 2024, 00:12 Brandon Istenes, @.***> wrote:

Closing this; author is not addressing feedback.

— Reply to this email directly, view it on GitHub https://github.com/openmrs/openmrs-esm-core/pull/963#issuecomment-2207308420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJC4NIN2MSDPDMBZEOGE3RDZKRSNJAVCNFSM6AAAAABFQKE2HCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGMYDQNBSGA . You are receiving this because you authored the thread.Message ID: @.***>

kitaroghope avatar Jul 04 '24 13:07 kitaroghope