jdk11u-dev

jdk11u-dev copied to clipboard

backport of c0dce25756911ce49e7d8b034d5f12a25fc3c81d 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"

1. Clean backport from tip
2. validated modified test case

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8236917 needs maintainer approval

Issue

• JDK-8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2712/head:pull/2712
$ git checkout pull/2712

Update a local copy of the PR:
$ git checkout pull/2712
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2712

View PR using the GUI difftool:
$ git pr show -t 2712

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2712.diff

Webrev

Link to Webrev Comment

:wave: Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dhanalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"

Use getTestJavaOpts() instead of getVmOptions() because of mach5 configuration settings.

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

• 8578e12c423ed61618e0b3ef81e5be3d18be1da2: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
• 6547a1687d06f7cb0ece182001babc57915f486b: 8227122: [TESTBUG] Create Docker sidecar test cases
• 25d6e19de54f24b4ce39b1481c25a6a9b83bbcac: Merge
• 1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1: 8334441: Mark tests in jdk_security_infra group as manual
• e61adf68ee4c4f3fc031836049d6e289452e8c68: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• 59cd1a45b167285c7bee6855274eed30263fedca: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
• 569c669891b0011ae9d7fe2593005c8d2ee4e3a6: 8305079: Remove finalize() from compiler/c2/Test719030
• 724477cfe4afd7f740d8905ee8d9d4de1a655714: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
• cc42090c322c024f09b84825ea87c235d47f16fc: 8306466: Open source more AWT Drag & Drop related tests
• 8489b52f1d03fce0b6cd08de88850e4234e61810: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
• ... and 81 more: https://git.openjdk.org/jdk11u-dev/compare/665e1cd4f976abf89a32c12a96642cbab2c5d157...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

This backport pull request has now been updated with issue and summary from the original commit.

Webrevs

• 02: Full - Incremental (65def81e)
• 01: Full - Incremental (ce9f75a6)
• 00: Full (132f4d94)

Adding a comment to keep this PR active.

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

/integrate

@dhanalla Your change (at version 65def81eaec114f4e6af2f1f8199aa5799004333) is now ready to be sponsored by a Committer.

/sponsor

Going to push as commit db9e3139dcf36da37db2f91ede59c051978af35e. Since your change was applied there have been 91 commits pushed to the master branch:

• 8578e12c423ed61618e0b3ef81e5be3d18be1da2: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
• 6547a1687d06f7cb0ece182001babc57915f486b: 8227122: [TESTBUG] Create Docker sidecar test cases
• 25d6e19de54f24b4ce39b1481c25a6a9b83bbcac: Merge
• 1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1: 8334441: Mark tests in jdk_security_infra group as manual
• e61adf68ee4c4f3fc031836049d6e289452e8c68: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• 59cd1a45b167285c7bee6855274eed30263fedca: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
• 569c669891b0011ae9d7fe2593005c8d2ee4e3a6: 8305079: Remove finalize() from compiler/c2/Test719030
• 724477cfe4afd7f740d8905ee8d9d4de1a655714: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
• cc42090c322c024f09b84825ea87c235d47f16fc: 8306466: Open source more AWT Drag & Drop related tests
• 8489b52f1d03fce0b6cd08de88850e4234e61810: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
• ... and 81 more: https://git.openjdk.org/jdk11u-dev/compare/665e1cd4f976abf89a32c12a96642cbab2c5d157...master

Your commit was automatically rebased without conflicts.

@TheRealMDoerr @dhanalla Pushed as commit db9e3139dcf36da37db2f91ede59c051978af35e.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.