cv32e40p icon indicating copy to clipboard operation
cv32e40p copied to clipboard

(partially) fix RVFI integration issues

Open MikeOpenHWGroup opened this issue 3 years ago • 3 comments

This PR resolves SV compile errors and warnings flagged by dsim:

  • bhv/cv32e40p_rvfi.sv: nonblocking assignments to automatic variables are not allowed (object variables are automatic by default). Dsim won't compile this but I expect VCS does.
  • bhv/cv32e40p_tb_wrapper.sv: dsim warns about several width mismatches. I did not resolve this, but they are flagged with FIXMEs.

MikeOpenHWGroup avatar Aug 10 '22 20:08 MikeOpenHWGroup

Hi @MikeOpenHWGroup - you should download Verible, checkout the version mentioned in the README and run verible (the script is in the util folder)

davideschiavone avatar Aug 11 '22 08:08 davideschiavone

Done. Verible wanted to make a lot of changes to both bhv and rtl files. I only pushed in the verible-ized versions of the files modified in this pull-request, namely bhv/cv32e40p_rvfi.sv and bhv/cv32e40p_tb_wrapper.sv.

MikeOpenHWGroup avatar Aug 12 '22 20:08 MikeOpenHWGroup

Done. Verible wanted to make a lot of changes to both bhv and rtl files. I only pushed in the verible-ized versions of the files modified in this pull-request, namely bhv/cv32e40p_rvfi.sv and bhv/cv32e40p_tb_wrapper.sv.

probably you.are not using the right version, indeed the CI still fails. if you want we can set a meeting and fix it

davideschiavone avatar Aug 13 '22 08:08 davideschiavone

Ha! I resubmitted using verible-verilog-format version v0.0-1149-g7eae750 and it seems to work.

MikeOpenHWGroup avatar Aug 15 '22 12:08 MikeOpenHWGroup