openFrameworks icon indicating copy to clipboard operation
openFrameworks copied to clipboard

Published 20 hours ago • verified publisher icon openframeworks

Deprecate macros (e.g. PI, RAD_TO_DEG, etc) and remove from the core, fixes #5163.

Open bakercp opened this issue 8 years ago • 7 comments

I think I've gotten all of them, the waiting on CI.

Fixes #5163

bakercp avatar May 21 '17 04:05 bakercp

@arturoc no?

bakercp avatar Oct 11 '19 04:10 bakercp

I would be in favor of this (with a bit of double checking it doesn't break anything) but I think we should have enable deprecated macros by default for a few versions.

Is it possible to do an inline warning when people use the old macros like PI or ABS? That really helps getting people to switch over.

ofTheo avatar Oct 11 '19 14:10 ofTheo

yes feel free to rebase and merge not sure why it wasn't merged before sorry

arturoc avatar Oct 11 '19 14:10 arturoc

I will work on rebasing this today.

bakercp avatar Oct 11 '19 17:10 bakercp

@bakercp if you are able to rebase and merge would be awesome. Otherwise @dimitre or I can take a stab at it. Thanks again for this!! 🙂

ofTheo avatar May 25 '22 23:05 ofTheo

Hi @ofTheo - unfortunately I don't have the bandwidth to merge this at the moment.

bakercp avatar May 26 '22 01:05 bakercp

No worries @bakercp, thanks for letting us know. 👍 I can pull this into another branch and do a PR.

To @ofZach's point I think we will need to update examples too ( see: https://github.com/openframeworks/openFrameworks/search?p=3&q=PI )

So I can take care of that. I think I'll aim to deprecate first ( so leave the legacy macro define for the next release ) then we can comment it out for the release after that.

Thanks for all of this!

ofTheo avatar May 26 '22 03:05 ofTheo