ofBook icon indicating copy to clipboard operation
ofBook copied to clipboard

Network chapter fixes

Open tpltnt opened this issue 10 years ago • 9 comments

Hi @arturoc please check my changes and merge if applicable. Cheers, tpltnt

tpltnt avatar Apr 27 '15 09:04 tpltnt

@bakercp I fixed all the issues you pointed out. Thank you.

tpltnt avatar Apr 27 '15 14:04 tpltnt

ping @arturoc

tpltnt avatar May 05 '15 13:05 tpltnt

ping @arturoc

tpltnt avatar Jun 01 '15 07:06 tpltnt

@arturoc could you please take a look at my changes? You haven't responded in quite a while. If you do not respond until 2015-07-21 (a month from now), i would consider this chapter abandoned (by you) and merge my changes. Please give an indication one way or another. Thank you.

tpltnt avatar Jun 20 '15 08:06 tpltnt

@tpltnt i've taken a look at your changes several times but it's complicated to merge, there's things that are very valuable like grammar corrections or the introduction to ip which was missing and it's important to understand but it's somehow too technical for the level i was aiming for, originally. Then there's annotations that need to be removed. There's also parts that are just wrong or too technical. I haven't had time to fix everything before merging.

In general there's too many things that i don't consider correct from a technical or pedagogical point of view and don't have the time to give you feedback on all of them. From my part i consider the chapter is finished so don't merge anything without the permission of the original authors unless is small fixes that are obviously wrong on the originals.

If you want to give a try at removing the annotations and explaining things in a simpler way i can try to give you some feedback but right now there's too many things that i don't consider correct to be able to give you feedback. Otherwise i can close this PR. Let me know what you prefer to do.

arturoc avatar Jun 20 '15 09:06 arturoc

@arturoc thank you for the feedback. I will try to address the annotations and will come back to you.

tpltnt avatar Jun 20 '15 15:06 tpltnt

@arturoc I removed the annotation and cleaned up a few things. Are you ok with merging?

tpltnt avatar Oct 22 '15 14:10 tpltnt

ping @arturoc

tpltnt avatar Apr 01 '16 21:04 tpltnt

@arturoc @tpltnt , what's the status of this PR?

edap avatar Oct 25 '18 20:10 edap