openff-evaluator from_json doesn't necessarily return an instance of the class

from_json doesn't necessarily return an instance of the class

Open lilyminium opened this issue 7 months ago • 0 comments

Describe the bug

This is minor but I was thrown that PhysicalPropertyDataSet.from_json(request_result_file) returned a RequestResult instead of throwing an error.

To Reproduce

from openff.evaluator.datasets.datasets import PhysicalPropertyDataSet
PhysicalPropertyDataSet.from_json("empty_result.json")

Output

Computing environment (please complete the following information):

Additional context

Using current main branch.

Mar 14 '25 06:03 lilyminium