js-libs icon indicating copy to clipboard operation
js-libs copied to clipboard

Convert @parity/api to TypeScript

Open amaury1093 opened this issue 7 years ago • 5 comments

It's the last package still in plain JS.

amaury1093 avatar Oct 16 '18 15:10 amaury1093

@yjkimjunior nice I just saw you assigned yourself, are you working on this?

Note: the way it's done right now, we can convert api to TS incrementally. See for example https://github.com/paritytech/js-libs/tree/42743c94a8c03c07f89ba0157874cc891e218cb3/packages/api/src, only util/ is in TS now. So feel free to tackle this bit by bit.

amaury1093 avatar Jan 02 '19 10:01 amaury1093

Had this on the backburner but working on it now. I'm starting by renaming files to .ts then seeing what breaks and then adding type definitions from there. Starting with building a interface for Contracts

pmespresso avatar Jan 03 '19 10:01 pmespresso

@yjkimjunior Would you mind if I took this? Just my kind of thing :)

After this, it might also be interesting to explore adding a TypeChain target https://github.com/ethereum-ts/TypeChain

JamesLefrere avatar Sep 11 '19 09:09 JamesLefrere

hey @JamesLefrere please go ahead, forgot to unassign myself

pmespresso avatar Sep 11 '19 11:09 pmespresso

@JamesLefrere Do you mind if I take the conversion of some components?

ksato9700 avatar Feb 29 '20 04:02 ksato9700