dynamic-nfs-provisioner icon indicating copy to clipboard operation
dynamic-nfs-provisioner copied to clipboard

feat: Added support for listing custom mountOptions

Open pentago opened this issue 3 years ago • 0 comments

Signed-off-by: pentago [email protected]

Pull Request template

It fixes mounting of a provisioned NFS server pod in situations where the following issue occurs:

Warning  FailedMount  1s (x3 over 3s)  kubelet   MountVolume.SetUp failed for volume "pvc-79743abd-d5c9-4939-a48d-d3038aa30d2a" : mount failed: exit status 255
Mounting command: mount
Mounting arguments: -t nfs 10.0.244.196:/ /var/lib/kubelet/pods/14af0af3-da2e-4276-92e6-eb39d0d57341/volumes/kubernetes.io~nfs/pvc-79743abd-d5c9-4939-a48d-d3038aa30d2a
Output: mount: mounting 10.0.244.196:/ on /var/lib/kubelet/pods/14af0af3-da2e-4276-92e6-eb39d0d57341/volumes/kubernetes.io~nfs/pvc-79743abd-d5c9-4939-a48d-d3038aa30d2a failed: Not supported

What this PR does?: Enables user to add custom NFS mount options

Does this PR require any upgrade changes?: No to my knowledge, maintainers please advise.

If the changes in this PR are manually verified, list down the scenarios covered:: Performed helm template to ensure proper output and tested deployment - worked fine.

Any additional information for your reviewer? : No.

Checklist:

  • [X] Fixes #140
  • [X] PR Title follows the convention of <type>(<scope>): <subject>
  • [ ] Has the change log section been updated?
  • [ ] Commit has unit tests
  • [ ] Commit has integration tests
  • [ ] (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #<PR number>
  • [ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • [ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them

@pawanpraka1 here's the new PR as I wasn't able to fix the previous one by force-pushing with the signoff message, hopefully, it gets merged soon.

pentago avatar Aug 15 '22 11:08 pentago