cobratoolbox icon indicating copy to clipboard operation
cobratoolbox copied to clipboard

checkStoichiometricConsistency and findStoichConsistentSubset indicate inconsistent metabolites as consistent

Open tpfau opened this issue 8 years ago • 2 comments

I tried to write a test for checkConsistency and findStoichConsistentSubset using the following network:

%   <-> A -----> B ---> C --> E <->
%        \       ^
%         \     /
%          -> 2 D 

According to the definition of stoichiometric consistency at least Metabolite D should be marked as inconsistent and in general, the whole network should be inconsistent. However, findStoichConsistentSubset indicated all Metabolites as consistent, and checkConsistency returned an inform value of 1 (i.e. indicated consistency). However here is no way to assign a non-zero weight to any of the metabolites since B can either consist of A or of half an A. For checkConsistency the reason is that the secondary problem solved simply sets inform to 1 (ignoring that all masses are zero). However I'm not sure what is causing the issue in findStoichConsistentSubset. @rmtfleming could you have a look at this?

I hereby confirm that I have:

  • [X] Retried to run my code with the latest version of The COBRA Toolbox
  • [X] Checked that a similar issue has not already been opened

(Note: You may replace [] with [X] to check the box)

tpfau avatar Sep 12 '17 11:09 tpfau

@tpfau this should be working now.

rmtfleming avatar Apr 17 '18 10:04 rmtfleming

Hi, At least on the latest development branch this model still leads to a result of true from the checkStoichiometricConsistency function and findStoichiConsistentSubset still returns all Metabolites as consistent.

tpfau avatar Apr 17 '18 11:04 tpfau