openai-quickstart-node icon indicating copy to clipboard operation
openai-quickstart-node copied to clipboard

adding empty input checking and removing default input outline

Open firasmlt opened this issue 3 years ago • 1 comments

Resolves #10 adding empty input checking also, I removed the default text input outline to improve the styling

firasmlt avatar Aug 11 '22 00:08 firasmlt

you can take a look at the implementation here.

firasmlt avatar Aug 11 '22 00:08 firasmlt

Thanks for opening this and sorry it took us a while to review. While doing client-side validation here can be helpful, I think addressing this issue with server-side validation (see 259a13a2c04b6ffff33da11ba57cdc9d333851e5) is slightly more robust.

Your changes looks good here, but our goal for the quickstart is to keep the code very simple, and having both client-side and server-side validation is probably unnecessary, so I'll close this PR. Appreciate you reporting the original issue!

schnerd avatar Dec 24 '22 17:12 schnerd