opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Improve proto generation rake task

Open ahayworth opened this issue 3 years ago • 1 comments

Use Dir.glob and clean it up.

Originally posted by @ahayworth in https://github.com/open-telemetry/opentelemetry-ruby/pull/1345#discussion_r941846248

ahayworth avatar Aug 09 '22 22:08 ahayworth

🤔 I've rediscovered Rake::FileList. Because this activity is occurring in a Rakefile,

proto_files = Rake::FileList["opentelemetry-proto/**/*.proto"]

… is also an option.

I am resisting trying to write Rake rules for .proto to .pb. I expect they would end up weird and hard to read.

robbkidd avatar Aug 10 '22 14:08 robbkidd

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

github-actions[bot] avatar Mar 30 '24 01:03 github-actions[bot]