opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

Metrics Accumulator split proposal

Open bogdandrutu opened this issue 4 years ago • 2 comments

Right now the Accumulator has a global map (InstrumentDescriptor + LabelSet) -> Record. This has an advantage of simpler code, but with this approach there is a chance of high contention on the global map.

The proposal is to split Accumulator into 2 parts:

Accumulator: global map InstrumentDescriptor -> InstrumentAccumulator InstrumentAccumulator: local to the instrument map between LabelSet -> Record

This way we can reduce contention on the global map when non-bound records are recorded.

bogdandrutu avatar Dec 09 '20 18:12 bogdandrutu

This will be important before we can vary the collection interval on a per-instrument basis. OTOH doesn't feel urgent to me.

jmacd avatar Dec 11 '20 16:12 jmacd

Marking as after GA. Please update if this is incorrect.

MrAlias avatar Jan 07 '21 17:01 MrAlias

Stale, closing.

MrAlias avatar Oct 12 '22 19:10 MrAlias