opentelemetry-collector

opentelemetry-collector copied to clipboard

This ensures the consistency for folks emitting metrics w/ OTLP until the OTEP to specify pipeline telemetry is completed.

Waiting on https://github.com/open-telemetry/opentelemetry-collector/pull/9775 before moving this forward

Mar 14 '24 19:03 codeboten

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.26%. Comparing base (6227646) to head (b030567). Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #9759      +/-   ##
==========================================
- Coverage   92.29%   92.26%   -0.03%     
==========================================
  Files         395      395              
  Lines       18706    18702       -4     
==========================================
- Hits        17264    17256       -8     
- Misses       1084     1086       +2     
- Partials      358      360       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mar 14 '24 19:03 codecov[bot]

One thing to note with this change is that metrics that are generated by an instrumentation library or by a component that instantiates its own metric will not be prefixed as the prefixing is now done manually. You can see an example of this in the results below

Here's the comparison of the metric names for both Prometheus and OTLP emitted metrics before and after this change.

Before this change

Prometheus metrics

# HELP otelcol_exporter_send_failed_spans Number of spans in failed attempts to send to destination.
# TYPE otelcol_exporter_send_failed_spans counter
otelcol_exporter_send_failed_spans{exporter="debug",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 0
# HELP otelcol_exporter_sent_spans Number of spans successfully sent to destination.
# TYPE otelcol_exporter_sent_spans counter
otelcol_exporter_sent_spans{exporter="debug",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 2
# HELP otelcol_process_cpu_seconds Total CPU user and system time in seconds
# TYPE otelcol_process_cpu_seconds counter
otelcol_process_cpu_seconds{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 0.05
# HELP otelcol_process_memory_rss Total physical memory (resident set size)
# TYPE otelcol_process_memory_rss gauge
otelcol_process_memory_rss{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 2.4100864e+07
# HELP otelcol_process_runtime_heap_alloc_bytes Bytes of allocated heap objects (see 'go doc runtime.MemStats.HeapAlloc')
# TYPE otelcol_process_runtime_heap_alloc_bytes gauge
otelcol_process_runtime_heap_alloc_bytes{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 3.010136e+06
# HELP otelcol_process_runtime_total_alloc_bytes Cumulative bytes allocated for heap objects (see 'go doc runtime.MemStats.TotalAlloc')
# TYPE otelcol_process_runtime_total_alloc_bytes counter
otelcol_process_runtime_total_alloc_bytes{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 4.247488e+06
# HELP otelcol_process_runtime_total_sys_memory_bytes Total bytes of memory obtained from the OS (see 'go doc runtime.MemStats.Sys')
# TYPE otelcol_process_runtime_total_sys_memory_bytes gauge
otelcol_process_runtime_total_sys_memory_bytes{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 1.2274704e+07
# HELP otelcol_process_uptime Uptime of the process
# TYPE otelcol_process_uptime counter
otelcol_process_uptime{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 11.321643
# HELP otelcol_processor_batch_batch_send_size Number of units in the batch
# TYPE otelcol_processor_batch_batch_send_size histogram
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="10"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="25"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="50"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="75"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="100"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="250"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="500"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="750"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="1000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="2000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="3000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="4000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="5000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="6000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="7000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="8000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="9000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="10000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="20000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="30000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="50000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="100000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="+Inf"} 1
otelcol_processor_batch_batch_send_size_sum{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 2
otelcol_processor_batch_batch_send_size_count{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 1
# HELP otelcol_processor_batch_metadata_cardinality Number of distinct metadata value combinations being processed
# TYPE otelcol_processor_batch_metadata_cardinality gauge
otelcol_processor_batch_metadata_cardinality{service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 1
# HELP otelcol_processor_batch_timeout_trigger_send Number of times the batch was sent due to a timeout trigger
# TYPE otelcol_processor_batch_timeout_trigger_send counter
otelcol_processor_batch_timeout_trigger_send{processor="batch",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev"} 1
# HELP otelcol_receiver_accepted_spans Number of spans successfully pushed into the pipeline.
# TYPE otelcol_receiver_accepted_spans counter
otelcol_receiver_accepted_spans{receiver="otlp",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",transport="grpc"} 2
# HELP otelcol_receiver_refused_spans Number of spans that could not be pushed into the pipeline.
# TYPE otelcol_receiver_refused_spans counter
otelcol_receiver_refused_spans{receiver="otlp",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",transport="grpc"} 0
# HELP otelcol_rpc_server_duration Measures the duration of inbound RPC.
# TYPE otelcol_rpc_server_duration histogram
otelcol_rpc_server_duration_bucket{rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="0"} 0
otelcol_rpc_server_duration_bucket{rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_instance_id="d64666ef-1bf6-48d1-9cfd-ab242e9f1f50",service_name="otelcorecol",service_version="0.96.0-dev",le="5"} 1

OTLP metrics

        {
          "Name": "processor/batch/metadata_cardinality",
          "Description": "Number of distinct metadata value combinations being processed",
          "Unit": "1",
          "Data": {
            "DataPoints": [
              {
                "Attributes": [],
                "StartTime": "2024-03-15T09:13:05.950473-07:00",
                "Time": "2024-03-15T09:13:09.265554-07:00",
                "Value": 1
              }
            ],
            "Temporality": "CumulativeTemporality",
            "IsMonotonic": false
          }

After this change

Prometheus metrics

# HELP otelcol_exporter_send_failed_spans Number of spans in failed attempts to send to destination.
# TYPE otelcol_exporter_send_failed_spans counter
otelcol_exporter_send_failed_spans{exporter="debug",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 0
# HELP otelcol_exporter_sent_spans Number of spans successfully sent to destination.
# TYPE otelcol_exporter_sent_spans counter
otelcol_exporter_sent_spans{exporter="debug",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 2
# HELP otelcol_process_cpu_seconds Total CPU user and system time in seconds
# TYPE otelcol_process_cpu_seconds counter
otelcol_process_cpu_seconds{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 0.04
# HELP otelcol_process_memory_rss Total physical memory (resident set size)
# TYPE otelcol_process_memory_rss gauge
otelcol_process_memory_rss{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 2.3904256e+07
# HELP otelcol_process_runtime_heap_alloc_bytes Bytes of allocated heap objects (see 'go doc runtime.MemStats.HeapAlloc')
# TYPE otelcol_process_runtime_heap_alloc_bytes gauge
otelcol_process_runtime_heap_alloc_bytes{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 3.023424e+06
# HELP otelcol_process_runtime_total_alloc_bytes Cumulative bytes allocated for heap objects (see 'go doc runtime.MemStats.TotalAlloc')
# TYPE otelcol_process_runtime_total_alloc_bytes counter
otelcol_process_runtime_total_alloc_bytes{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 4.268616e+06
# HELP otelcol_process_runtime_total_sys_memory_bytes Total bytes of memory obtained from the OS (see 'go doc runtime.MemStats.Sys')
# TYPE otelcol_process_runtime_total_sys_memory_bytes gauge
otelcol_process_runtime_total_sys_memory_bytes{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 1.2274704e+07
# HELP otelcol_process_uptime Uptime of the process
# TYPE otelcol_process_uptime counter
otelcol_process_uptime{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 7.331369
# HELP otelcol_processor_batch_batch_send_size Number of units in the batch
# TYPE otelcol_processor_batch_batch_send_size histogram
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="10"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="25"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="50"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="75"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="100"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="250"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="500"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="750"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="1000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="2000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="3000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="4000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="5000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="6000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="7000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="8000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="9000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="10000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="20000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="30000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="50000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="100000"} 1
otelcol_processor_batch_batch_send_size_bucket{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="+Inf"} 1
otelcol_processor_batch_batch_send_size_sum{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 2
otelcol_processor_batch_batch_send_size_count{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 1
# HELP otelcol_processor_batch_metadata_cardinality Number of distinct metadata value combinations being processed
# TYPE otelcol_processor_batch_metadata_cardinality gauge
otelcol_processor_batch_metadata_cardinality{service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 1
# HELP otelcol_processor_batch_timeout_trigger_send Number of times the batch was sent due to a timeout trigger
# TYPE otelcol_processor_batch_timeout_trigger_send counter
otelcol_processor_batch_timeout_trigger_send{processor="batch",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev"} 1
# HELP otelcol_receiver_accepted_spans Number of spans successfully pushed into the pipeline.
# TYPE otelcol_receiver_accepted_spans counter
otelcol_receiver_accepted_spans{receiver="otlp",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",transport="grpc"} 2
# HELP otelcol_receiver_refused_spans Number of spans that could not be pushed into the pipeline.
# TYPE otelcol_receiver_refused_spans counter
otelcol_receiver_refused_spans{receiver="otlp",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",transport="grpc"} 0
# HELP rpc_server_duration Measures the duration of inbound RPC.
# TYPE rpc_server_duration histogram
rpc_server_duration_bucket{rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="0"} 0
rpc_server_duration_bucket{rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="5"} 1
rpc_server_duration_bucket{rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="10"} 1
rpc_server_duration_bucket{rpc_grpc_status_code="0",rpc_method="Export",rpc_service="opentelemetry.proto.collector.trace.v1.TraceService",rpc_system="grpc",service_instance_id="0fd7a1f3-3a39-4825-b8f7-9146185f98fb",service_name="otelcorecol",service_version="0.96.0-dev",le="25"} 1

OTLP metrics

        {
          "Name": "otelcol_processor_batch_metadata_cardinality",
          "Description": "Number of distinct metadata value combinations being processed",
          "Unit": "1",
          "Data": {
            "DataPoints": [
              {
                "Attributes": [],
                "StartTime": "2024-03-15T09:07:20.89055-07:00",
                "Time": "2024-03-15T09:07:56.470161-07:00",
                "Value": 1
              }
            ],
            "Temporality": "CumulativeTemporality",
            "IsMonotonic": false
          }
        }

Mar 15 '24 16:03 codeboten

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Mar 30 '24 03:03 github-actions[bot]

@codeboten I updated https://github.com/open-telemetry/opentelemetry-collector/pull/9767. It'd be great to merge that PR first in order to disable the grps/http instrumentation metrics by default before changing their names

Apr 16 '24 17:04 dmitryax

@codeboten I updated #9767. It'd be great to merge that PR first in order to disable the grps/http instrumentation metrics by default before changing their names

@dmitryax i think that's fine, we can get #9767 merged and released in 0.99.0 and then this change can go out on the following release

Apr 16 '24 18:04 codeboten

This PR was marked stale due to lack of activity. It will be closed in 14 days.

May 01 '24 03:05 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

May 16 '24 03:05 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Jun 01 '24 03:06 github-actions[bot]

@codeboten are we waiting on anything for this PR to continue?

Jun 05 '24 15:06 jaronoff97

@jaronoff97 yeah im just wrapping up the mdatagen work, which will make this PR as easy as updating metadata.yaml files to add the prefix.

Jun 05 '24 18:06 codeboten

@jaronoff97 see:

• https://github.com/open-telemetry/opentelemetry-collector/pull/10316
• https://github.com/open-telemetry/opentelemetry-collector/pull/10318
• https://github.com/open-telemetry/opentelemetry-collector/pull/10273

Jun 05 '24 18:06 codeboten

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Jun 25 '24 03:06 github-actions[bot]

This is blocked on https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/29867, i've not forgotten about this PR

Jul 02 '24 23:07 codeboten

@jpkrohling @jaronoff97 this is ready to move forward now.

Most components in core and contrib using mdatagen for metric generation which allows me to make the prefix change in mdatagen instead of having to rename all the metrics in metadata.yaml.

This forces any metrics listed in telemetry::metrics to be prefixed, which I think is what we want for all internal metrics to be prefixed consistently. Note that the documentation generated shows the metric including the prefix.

Jul 12 '24 15:07 codeboten