opentelemetry-collector-releases icon indicating copy to clipboard operation
opentelemetry-collector-releases copied to clipboard

Consistency for configuration for distros

Open codeboten opened this issue 1 year ago • 3 comments
trafficstars

Configuration is in different places for the different distros:

# contrib
/etc/otelcol-contrib/config.yaml
# core
/etc/otelcol/config.yaml
# k8s distro
No conf

It would be great to have it be consistent

codeboten avatar Apr 17 '24 16:04 codeboten

This was intentional https://github.com/open-telemetry/opentelemetry-collector-releases/issues/59#issuecomment-1014451868

I don't like having a default config because:

  • It leads to a silent failure (using the default config) if you get the command wrong/mount the config in the wrong place
  • The default config is not useful outside of a demo, it just uses the debug exporter. Additionally, I don't think any config would be helpful, we can't really predict users use case here

Although removing the default config is a breaking change, the blast radius is probably going to be more reduced (at least if we keep the entrypoint as is), since most people are not using the default configuration

mx-psi avatar Apr 17 '24 16:04 mx-psi

I agree on removing default config

TylerHelmuth avatar Apr 17 '24 16:04 TylerHelmuth

I'm also in favor of removing the default config.

It leads to a silent failure (using the default config) if you get the command wrong/mount the config in the wrong place

I've seen this many times as well.

jpkrohling avatar Apr 19 '24 14:04 jpkrohling