opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[exporter/prometheusexporter] accumulate delta temporality metrics

Open nabam opened this issue 3 years ago • 10 comments

Description: Accumulate delta temporality metrics in prometheus exporter to expose as monotonically increasing counters

Link to tracking Issue: related to #4968

nabam avatar Apr 01 '22 18:04 nabam

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Apr 19 '22 05:04 github-actions[bot]

any chance someone can review this PR? @bogdandrutu

nabam avatar Apr 27 '22 17:04 nabam

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar May 13 '22 05:05 github-actions[bot]

@Aneurysm9 @bogdandrutu just a friendly poke here. Let me know if that's and appropriate approach and I'll rebase.

nabam avatar May 19 '22 11:05 nabam

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jun 04 '22 05:06 github-actions[bot]

it is still relevant @jmacd maybe you can take a look?

nabam avatar Jun 08 '22 18:06 nabam

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jul 04 '22 05:07 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

not stale

nabam avatar Jul 07 '22 09:07 nabam

Could you explain how this relates to https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/9919? It looks like it continues refining that work. The PR description could use some details on what changes are happening here, since the linked issue is quite broad. Thank you.

(I'm still eager to see this form of translation happen in both the Prometheus and PRW exporters.)

jmacd avatar Jul 08 '22 14:07 jmacd

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Aug 07 '22 05:08 github-actions[bot]

Answering my own question above. This adds support for Delta->Cumulative for histograms, whereas #9919 only fixed the problem for Sums. @nabam agree? Will you update this PR?

jmacd avatar Aug 17 '22 16:08 jmacd

@jmacd yeah, I will. Sorry I haven't replied, was on vacation

nabam avatar Aug 17 '22 16:08 nabam

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: nabam / name: Lev Popov (3bf08f26b55d92944dbb1d9e05f59cee1f0ab543)

linux-foundation-easycla[bot] avatar Aug 18 '22 13:08 linux-foundation-easycla[bot]

@jmacd ready for your review

nabam avatar Aug 18 '22 14:08 nabam

Hi. Is there any estimated/guestimated time when this will be ready?

mike-jc avatar Aug 23 '22 07:08 mike-jc

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Oct 14 '22 05:10 github-actions[bot]

Could I ask you to rebase this PR @nabam ?

MovieStoreGuy avatar Jan 26 '23 05:01 MovieStoreGuy

Lev has left. I'll have to do this. I'll inform you once this will be done. We are really depend on this moving forward

bitomaxsp avatar Apr 24 '23 18:04 bitomaxsp

Hi there! Sorry, I had very little time lately to look into this since I got a new job recently. I can see that @locmai took this PR over and created https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/20530. Thanks a lot for getting it done! I'm closing this PR.

nabam avatar Apr 24 '23 18:04 nabam