opentelemetry-collector-contrib

opentelemetry-collector-contrib copied to clipboard

Signed-off-by: John D [email protected]

Description: Add the ability to change Span.Kind

Link to tracking Issue: #6883

Testing: New unit tests added

Documentation: README.md updated

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@ @Aneurysm9 @pmm-sumo can I get somen eyes on this?

I believe this PR duplicates functionality that already exists in the transformprocessor. I'm not saying thats unacceptable necessarily, but this is possible to do in the collector today.

@open-telemetry/collector-contrib-approvers how do we want to handle duplicate functionality? @boostchicken would users always need a unique instance of the spanprocessor thats dedicated to changing span.kind or could it be added to an existing config of the processor? Is it conditional, or would every incoming span have its kind updated?

@open-telemetry/collector-contrib-approvers how do we want to handle duplicate functionality? @boostchicken would users always need a unique instance of the spanprocessor thats dedicated to changing span.kind or could it be added to an existing config of the processor? Is it conditional, or would every incoming span have its kind updated?

Please see the issue. The SpanProcessor is the problem this. I am not aware of this being a duplicate functionality.

Ahhh I found it. I would suggest this belongs here. This is existing, you could add it to any span processor.

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Closed as inactive. Feel free to reopen if this PR is still being worked on.