pg_amqp

pg_amqp copied to clipboard

Looking for anyone that would be able to work on implementing this with the current version and bundle it as an extension update.

Mar 15 '16 20:03 keithf4

I can try to merge the ssl branch with the current master. But are there any plans to integrate this into master/develop?

Mar 16 '16 09:03 marcelloceschia

updated ssl branch

Mar 16 '16 11:03 marcelloceschia

I do plan on doing my best to try and get this pulled into the master branch if possible. C is not my strong suit at the moment, so may take a while.

Mar 30 '16 17:03 keithf4

@keithf4 If you have any questions, feel free to contact me. I have the latest version from ssl branch running in one productive environment that requires ssl connections.

Mar 30 '16 17:03 marcelloceschia

So I think I'd like to see about getting the updated librabbitmq library in place before trying to get this pulled in.

https://github.com/omniti-labs/pg_amqp/pull/18

Seems that would be better long term to make sure the base libraries are up to date and working before pulling in a new major feature like this. I'm going to be testing out that pull request to the best of my ability to make sure all the basic stuff is working and will then push out a new version. Could use any additional assistance you can provide testing that then.

Mar 30 '16 18:03 keithf4

That's a good idea. If you create a feature branch with the latest library version, I will reimplement the ssl support against this branch and you can publish a new version 0.5.0 with latest library version and ssl support

Mar 30 '16 18:03 marcelloceschia

It appears that @[email protected] changed signature and the old one was removed? Am I reading that diff correctly? If so, this would break existing clients of the extension. Can you confirm the old function signature is left in place and "does the right thing?"

Feb 20 '17 13:02 postwait

@postwait yes @[email protected] signature changed. But if you read this carefully, you will see that this only extends the old signature:

old:

CREATE FUNCTION @[email protected](broker_id integer, exchange varchar, routing_key varchar, message varchar, delivery_mode integer default null, content_type varchar default null, reply_to varchar default null, correlation_id varchar default null)

new:

CREATE FUNCTION @[email protected](broker_id integer, exchange varchar, routing_key varchar, message varchar, delivery_mode integer default null, content_type varchar default null, reply_to varchar default null, correlation_id varchar default null, headers varchar[][2] default null, properties varchar[][2] default null)

to allow header routing as well. But I will do this PR for a newer version of the amqp library as discussed with @keithf4

Feb 20 '17 15:02 marcelloceschia