Miguel Ojeda comments

Results 72 comments of


                                            Miguel Ojeda

RFC: Custom logo/favicon command-line flags

Thanks @Nemo157! Yeah, in that RFC, this: > There are two options that will be impacted by this RFC: the favicon and logo that you can respectively set through: >...

[BUG]: It has become hard to build Rust code with older compilers

Yeah, this was my concern and why the proposal I made on https://github.com/compiler-explorer/compiler-explorer/issues/3765 suggested pre-filling the flags box rather than doing something implicit. The actual change happened at https://github.com/compiler-explorer/compiler-explorer/pull/5001, which...

Add enum option `constified_enum + rustified_enum` with conversions

> As I'm understanding it, we just want a `TryFrom` and a wrapper for `transmute`, is that correct? A safe, fallible way may be enough, but it depends on the...

Tracking Issue for RFC 3013: Checking conditional compilation at compile time

Thanks for this feature! I gave it a try in the kernel: it was easy to set up and seemed to work as expected, with nice errors for small typos,...

Tracking Issue for RFC 3013: Checking conditional compilation at compile time

> @ojeda any performance concerns with checking 20k cfg's? We did some basic testing on the `windows` package because that has "a lot" of features but 20k is in a...

"cargo install" apparently ignores "Cargo.lock" as opposed to "cargo build"

It is surprising, indeed, and a security concern too: consider projects/apps that may just provide source tarballs or a repo somewhere, specially small ones within the Linux ecosystem. End-users will...

"cargo install" apparently ignores "Cargo.lock" as opposed to "cargo build"

> If Cargo used the original Cargo.lock, all of those binary projects would need to publish an update, otherwise all users will get the old version. There are several problems...

"cargo install" apparently ignores "Cargo.lock" as opposed to "cargo build"

> run a basic `cargo check` on the tool in a docker container to make sure it builds at least and only update the lockfile on success Failing to build...

feature: wrap every C function on unsafe blocks

If they are truly safe to call (which is rare, but it does happen sometimes), then I agree it could be nice to automate. However, doing it unconditionally is typically...

ci: Add Rust for Linux

In e.g. https://github.com/rust-lang/rust-bindgen/actions/runs/9568431855/job/26378640703?pr=2851 you can see at the bottom: ``` RUSTC L rust/core.o BINDGEN rust/bindings/bindings_generated.rs BINDGEN rust/bindings/bindings_helpers_generated.rs BINDGEN rust/uapi/uapi_generated.rs EXPORTS rust/exports_core_generated.h RUSTC P rust/libmacros.so RUSTC L rust/compiler_builtins.o RUSTC L rust/alloc.o...