d3-celestial icon indicating copy to clipboard operation
d3-celestial copied to clipboard

Published 20 hours ago • verified publisher icon ofrohn

refactor to es6 module

Open alephpi opened this issue 2 years ago • 2 comments

hi, thanks for your excellent work! I am trying to play it with vue and make use of tree-shakable feature with es6 modules. do you plan to refactor it (as well as bump the d3 dependency to latest version)? i know it will cost much time, do you have an idea how to do it? maybe i'll start from src/celestial.js.

thank you!

alephpi avatar Jun 20 '23 07:06 alephpi

Hi, I'm looking into your source code now. I wonder why here you divide by 1024 when compute the scale? Also, how did you get those 'magic' scale number for different projections? (e.g. aitoff scale is 162)

alephpi avatar Jun 22 '23 08:06 alephpi

Hi, I'm looking into your source code now. I wonder why here you divide by 1024 when compute the scale? Also, how did you get those 'magic' scale number for different projections? (e.g. aitoff scale is 162)

see comment here

alephpi avatar Jun 22 '23 19:06 alephpi