runbot icon indicating copy to clipboard operation
runbot copied to clipboard

Published 20 hours ago • verified publisher icon odoo

Don't send detachment notification on closed / merged parent

Open xmo-odoo opened this issue 1 year ago • 1 comments

302fd42cae2cbe54778d018aa8fafa51c201dfec added a notification to the parent of a PR being detached, to notify the dev that they need to merge it separately.

However it doesn't check the state of the parent in question is already merged / closed, so the developer can get a notification that they need to merge an already merged PR.

xmo-odoo avatar Feb 27 '24 13:02 xmo-odoo

Also when transitioning a PR from merged to closed (because reasons) a message gets sent to both the PR being closed and its parent, which is weird.

xmo-odoo avatar Mar 08 '24 15:03 xmo-odoo