Owen Derby

Results 27 comments of Owen Derby

Approach looks more or less fine to me. I'd say go ahead and get that backend work up for code review.

Okay - I think all coding is done. #305 is now merged - @nickoneill I'm holding off on merging https://github.com/5calls/callserve/pull/20 because that requires #305 to be deployed first. We also...

Thanks for taking a stab at this @cdoremus. Running short on time, but after a cursory read, this looks good to me. I think we could clarify how unit tests...

@nickoneill what do you mean by that last comment? Will the /report API now return a breakdown including test calls? I had assumed we'd just discard them in the backend...

I'd be surprised if someone hasn't already written the logic to simulate/polyfill the host property - afterall, it should be deterministic given the href, right? I'm sure there are some...

I'm very excited for type annotations for Rtree - thanks for all the work so far. Unfortunately I noticed that Mypy gave some warnings with the v1.0.0 Rtree. I just...

Sorry, github never notified me of this. MIT is fine by me.