plugin-retry.js icon indicating copy to clipboard operation
plugin-retry.js copied to clipboard

Published 20 hours ago • verified publisher icon octokit

Remove `// @ts-ignore` statements

Open gr2m opened this issue 5 years ago • 2 comments

I had to rush the transition to TypeScript a little bit. Instead of setting the correct types everywhere, I've added a few // @ts-ignore statements: https://github.com/octokit/plugin-retry.js/search?q=%22%2F%2F+%40ts-ignore%22&unscoped_q=%22%2F%2F+%40ts-ignore%22

I'd love a pull request that remove them and sets the correct types instead. Ask away if you have any questions

gr2m avatar Jan 16 '20 00:01 gr2m

Hey @gr2m! I'd love to work on this if this is still a valid issue

copperwall avatar Jun 29 '20 07:06 copperwall

All yours :) There are @ts-ignore statements left in wrap-request.ts and error-request.ts

gr2m avatar Jun 29 '20 17:06 gr2m