add Goerli

• add Goerli to network selector
• switch subgraph typings generation to goerli subgraph
• remove Ropsten & Rinkeby
• remove Ropsten & Rinkeby from localStorage-saved user preferences
• for https://github.com/oceanprotocol/pm/issues/178

resulting in new network defaults:

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
market	✅ Ready (Inspect)	Visit Preview	Sep 30, 2022 at 1:45PM (UTC)

Wait, don't kick out rinkeby and ropten.

yup yup, will add them back to network selector

incorrect ocean value in wallet console error: RROR: Failed to get the balance: Returned values aren't valid, did it run Out of Gas? You might also see this error if you are not using the correct ABI for the contract you are retrieving data from, requesting data from a block number that does not exist, or querying a node which is not fully synced. A first guess would be incorrect ocean token address

console error:

Getting this error only when switching networks, no matter if Görli or not. But on other networks the balance then is correct despite this error message so this might be caused by some too early call before all values are present for it. I don't get this error when already connected to Görli before reloading app.

Contract address is correct, was able to add Görli OCEAN to MetaMask with that address

Think I got it, the OCEAN contract address we get from contracts and from the approved token query are different, and the latter is used to fetch balance.

Contracts say 0xCfDdA22C9837aE76E0faA845354f33C62E03653a but approved token query says 0xd8992ed72c445c35cb4a2be468568ed1079357c8. Contracts is correct, approved token query is not.

@alexcos20 can you please update the approved token so it's the correct ocean token address.

Also blocked by https://github.com/oceanprotocol/aquarius/issues/893

the market's OCEAN balance is not updating. I have some on my wallet, but the market is not reflecting that:

the market's OCEAN balance is not updating. I have some on my wallet, but the market is not reflecting that:

Anything in the browser console?

Anything in the browser console?

Nope. Unfortunately, there's no error thrown.

the market's OCEAN balance is not updating.

got it, and it's still this issue so nothing we can do on market

added 0xCfDdA22C9837aE76E0faA845354f33C62E03653a removed 0xd8992Ed72C445c35Cb4A2be468568Ed1079357c8

it should be fine now

getting balance on Görli seems really flaky, only successful every 2nd or 3rd reload for me

The approved token query seems to still return 0xd8992Ed72C445c35Cb4A2be468568Ed1079357c8 for me, or more precisely both of them. And then sometimes balance actually works, pretty sure double OCEAN token being defined is the issue:

@alexcos20 confirmed the subgraph returns both of them, do we need to have it reindex or something?:

that's definitely a bug on the subgraph, I can see TokenRemoved event on router contract:

https://goerli.etherscan.io/address/0x159924ca0f47d6f704b97e29099b89e518a17b5e#events

that's definitely a bug on the subgraph

cool, thanks for figuring out. For now added in a hacky filter in 4914314 so at least it works now and we are not forced to rush that subgraph fix.

An aquarius update was made and it seems to be working now. So, i guess we can merge this.

bug was fixed on subgraph as well

Code Climate has analyzed commit 237aecca and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 4.2% (0.0% change).

View more on Code Climate.