aquarius icon indicating copy to clipboard operation
aquarius copied to clipboard

refactor main loop

Open alexcos20 opened this issue 3 years ago • 1 comments

alexcos20 avatar Oct 20 '22 16:10 alexcos20

will rewrite tests later today

alexcos20 avatar Nov 08 '22 15:11 alexcos20

I had to revert 6ef8945 (sorry about the typo in commit name) because tests have to be rewritten.

there is a function called "deploy_datatoken" which actually deploys a NFT :) and in all of our tests, we don't have datatokens and valid ddos, so we are going to rewrite them in a proper way later

alexcos20 avatar Nov 08 '22 21:11 alexcos20

Code Climate has analyzed commit 71115b04 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 66.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.7% (-1.7% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Nov 09 '22 09:11 qlty-cloud-legacy[bot]

Code Climate has analyzed commit f0f56d60 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 9

The test coverage on the diff in this pull request is 70.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 84.5% (-3.9% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Dec 16 '22 09:12 qlty-cloud-legacy[bot]