vscode-ocaml-platform

vscode-ocaml-platform copied to clipboard

This PR converts the three vscode-test runners to OCaml by adding a few extra bindings to the various JS packages. This is in partial fulfilment of #393 (it doesn't bind mocha and the like, this could be a follow-up PR perhaps or I can revisit this PR next week to add that).

cc: @tmattio

Thanks @patricoferris, this is great!

This is in partial fulfilment of #393 (it doesn't bind mocha and the like, this could be a follow-up PR perhaps or I can revisit this PR next week to add that).

Up to you, we can leave it until next week open if you want to continue working on it, but I'm fine with merging as-is.

To reduce the number of files perhaps bundling it into the existing FS bindings might be a good idea seeing as they're already an altered form of the "true" Node FS module

Could you, please, then leave a comment explaining why you're doing so to avoid confusion in the future?

On Tue, 2 Nov 2021 at 17:14, Thibaut Mattio @.***> wrote:

@.**** commented on this pull request.

In src-bindings/fs-extra/fsextra_stub.js https://github.com/ocamllabs/vscode-ocaml-platform/pull/762#discussion_r741254845 :

@@ -0,0 +1 @@

+joo_global_object.fsExtra = require('fs-extra')

To reduce the number of files perhaps bundling it into the existing FS bindings might be a good idea seeing as they're already an altered form of the "true" Node FS module ?

Sure, that sounds good 🙂

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ocamllabs/vscode-ocaml-platform/pull/762#discussion_r741254845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4YR65GWRMPLBOOU2PVGBDUKAE7XANCNFSM5HG2APCQ .

@patricoferris is this PR ready?

Sorry for the delay doing some more testing locally first to debug https://github.com/ocamllabs/vscode-ocaml-platform/runs/4082355161?check_suite_focus=true

Please re-open if you ever get around to do this.