dune icon indicating copy to clipboard operation
dune copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Fix partial-match warnings

Open kit-ty-kate opened this issue 1 year ago • 1 comments

With this change, dune can now be compiled with OCAMLPARAM=warn-error=+8,_ again. Alternative to https://github.com/ocaml/dune/pull/10224

@rgrinberg was that what you were thinking of?

kit-ty-kate avatar May 07 '24 11:05 kit-ty-kate

Thanks. The warnings looks right, however I think we're not yet ready for this code because we still use opam's library to unpack local archives - but not downloaded ones. You can see how we unpack archives in fetch_curl, so you can just steal some of that and make it work for local files and delete fetch_others completely.

rgrinberg avatar May 11 '24 01:05 rgrinberg

I won't have time to work on that. Can anyone else take over?

kit-ty-kate avatar May 14 '24 11:05 kit-ty-kate

The parts described by Rudi have now landed as #10556 and #10561.

emillon avatar May 24 '24 14:05 emillon

The parts described by Rudi have now landed as #10556 and #10561.

Thank you so much!

kit-ty-kate avatar May 27 '24 11:05 kit-ty-kate

After a restart, CI is now green

kit-ty-kate avatar Jun 11 '24 21:06 kit-ty-kate