effects-examples icon indicating copy to clipboard operation
effects-examples copied to clipboard

Testing of `promises.ml` seems incomplete

Open ejgallego opened this issue 1 year ago • 5 comments

Dear effects examples maintainers,

thanks for the very nice examples on OCaml effects, they are very helpful!

@bhaktishh and I were looking into the promises.ml example, however we have noticed that the way the test are written, it seems that we never call the Wait effect, as all the promises are resolved immediately.

It seems to us that having a more complete test could be useful, what do you think?

We have a few ideas on how to solve this, let us know what do you think?

I guess the first to try would be to decouple promise creation from resolution, but we'd like to hear your opinion before trying to do a pull request.

ejgallego avatar Mar 22 '24 18:03 ejgallego