obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

Stopping and Starting the replay buffer can sometimes misleadingly say "Start Replay Buffer" highlighted in Blue - when the buffer is not actually running

Open ipaqmaster opened this issue 1 year ago • 3 comments

Operating System Info

Other

Other OS

Arch Linux 6.6.9

OBS Studio Version

30.1.0-beta1

OBS Studio Version (Other)

30.0.2

OBS Studio Log URL

https://obsproject.com/logs/7dMcegktuCWy5ECG

OBS Studio Crash Log URL

No response

Expected Behavior

The replay buffer to start

Current Behavior

The replay buffer sometimes doesn't start, but the button becomes filled with blue as if it has started (Despite the text remaining the same) which is misleading and has lead to me missing many potential clips the past year.

Steps to Reproduce

  1. Do something potentially requiring a save of the Replay Bufrfer
  2. "Flush" the Replay Buffer by toggling it off and on again to trim the beginning of a potential clip.
  3. Sometimes clicking the Replay Buffer will cause it to change it background color to blue, indicating the buffer has started. Sometimes, it actually still says "Start Replay Buffer" and has not actually toggled the feature on.

This leads to many lost potential clips. ...

Anything else we should know?

No response

ipaqmaster avatar Feb 04 '24 03:02 ipaqmaster

This continues to happen extremely frequently multiple times an hour. I go to clip something only to realize the highlighted blue button was false and the internal state was not recording anything at all.

This also happened with the regular recording button where over an hours worth of footage was lost due to this UI bug.

ipaqmaster avatar Mar 29 '24 11:03 ipaqmaster

Still a huge problem. Easily reproducible by toggling the buffer off/on within a second. The UI doesn't update and misleadingly loses clips by pretending to be ready.

ipaqmaster avatar Apr 15 '24 09:04 ipaqmaster

I suspect this is directly related to the UI element not updating and this code snippet https://github.com/obsproject/obs-studio/blob/83383c13bc5657fb7ef071d6e250a66d66cdcc95/UI/window-basic-main.cpp#L1915-L1921

I'll compile some variations to see if I can fix this with something small.

ipaqmaster avatar Apr 19 '24 00:04 ipaqmaster