thanos-receive-controller icon indicating copy to clipboard operation
thanos-receive-controller copied to clipboard

Support Multi-AZ in HashRing Config

Open christopherzli opened this issue 1 year ago • 3 comments

As thanos support az aware hashring config starting from v0.32: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental, we should support multi az in the controller to update config as well.

christopherzli avatar Jan 10 '24 07:01 christopherzli

pull request here: https://github.com/observatorium/thanos-receive-controller/pull/129

christopherzli avatar Jan 25 '24 02:01 christopherzli

This would appreciated. At the moment it seems to not support Ketama AZ-aware hashring as mentioned in Thanos official documentation here: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental

Using the config provided in Thanos doc results in the controller throwing error

level=warn caller=main.go:547 ts=2024-05-01T04:56:39.561782951Z msg="failed to decode configuration" err="json: cannot unmarshal object into Go struct field HashringConfig.endpoints of type string"

algo7 avatar May 01 '24 05:05 algo7

thanks @algo7 , hope this PR could be reviewed soon 😄

christopherzli avatar May 01 '24 06:05 christopherzli

PR merged 😄

christopherzli avatar May 16 '24 18:05 christopherzli