Nicholas C. Zakas

Results 1756 comments of Nicholas C. Zakas

::shrugs:: From a parser implementer point of view, I'd prefer having things in one spot. I also don't feel super strongly about, so I'd defer to consensus.

AFAIK, you are correct. Keep in mind that an identifier can have more than one Unicode code point escaped character, so the only possible flag would be to say, "somewhere...

@RReverser any thoughts on this?

I actually love the Acorn extension because I think it's incredibly useful. However, I believe that this proposal would be a breaking change, and we generally not accepted breaking changes...

Im not sure how much value a shorthand property adds at this point. Because existing ESTree producers may not update their implementation, you can’t just use `if (node.shorthand)` and would...

@RReverser my point is that adding shorthand means you’ll always need to check shorthand and local vs imported because you’ll always need to take into account that shorthand can be...

@rreverser do you want to move forward with this or should it be closed?

How would you like to proceed? If you’d like to push forward, I’d suggest summarizing the discussion to this point to make it easier to pick up for others.

I was able to reproduce the missing indent here: https://printcss.live/wMvbmYpbYA Still having trouble reproducing the missing line of text.