pwa-module icon indicating copy to clipboard operation
pwa-module copied to clipboard

[#356] Allow passing an array of ogImages

Open FelixRe0 opened this issue 5 years ago • 1 comments

I have dafted an idea, but I'm not sure why the additonal images are not added to the head. Every element except the first has an unique hid added (hid + index position).

{ hid: 'og:image', name: 'og:image', property: 'og:image', content: 'https://example.org/image-standard.png' }, { hid: 'og:image:width', name: 'og:image:width', property: 'og:image:width', content: 1200 }, { hid: 'og:image:height', name: 'og:image:height', property: 'og:image:height', content: 630 }, { hid: 'og:image:type', name: 'og:image:type', property: 'og:image:type', content: 'image/png' }, { hid: 'og:image:1', name: 'og:image', property: 'og:image', content: 'https://example.org/image-square.png' }, { hid: 'og:image:width:1', name: 'og:image:width', property: 'og:image:width', content: 400 }, { hid: 'og:image:height:1', name: 'og:image:height', property: 'og:image:height', content: 400 }, { hid: 'og:image:type:1', name: 'og:image:type', property: 'og:image:type', content: 'image/png' }

=> They are added correctly to the meta array

Any ideas?

FelixRe0 avatar Oct 19 '20 09:10 FelixRe0

Codecov Report

Merging #380 (e08e029) into main (3ebfd1a) will increase coverage by 0.11%. The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   84.67%   84.78%   +0.11%     
==========================================
  Files          12       12              
  Lines         398      401       +3     
  Branches      121      123       +2     
==========================================
+ Hits          337      340       +3     
  Misses         56       56              
  Partials        5        5              
Impacted Files Coverage Δ
lib/meta/module.js 79.00% <40.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ebfd1a...e08e029. Read the comment docs.

codecov[bot] avatar Oct 19 '20 09:10 codecov[bot]