nx
                                
                                 nx copied to clipboard
                                
                                    nx copied to clipboard
                            
                            
                            
                        feat(js): fine-grained dep type support for publishable libs
Allows lib package.json to define its dependencies appropriately between dependencies and peerDependencies, while providing a way to continue to inherit the workspace's pkg version
e.g. "foo": "[inherit]"
Current Behavior
If the options to update the package is true and a dependency is declared in the libraries package.json, it would not be updated.
Expected Behavior
If dependency is declared with "magic" string === [inherit].  The version will be updated from workspace package.json for that dependency.
This allows a library to maintain finer control over whether to use dependencies or peerDependencies for a given package, without giving up the ability to inherit the workspace's package.json version.
Related Issue(s)
Fixes #10550
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 392e191d84eaf0267b4639b98dd56b2f27e28225. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 12 targets
- nx affected --target=build --base=c0a0f1691373996f1b76622143c5646168ef1eb3 --head=392e191d84eaf0267b4639b98dd56b2f27e28225 --parallel=3
- nx affected --target=e2e --base=c0a0f1691373996f1b76622143c5646168ef1eb3 --head=392e191d84eaf0267b4639b98dd56b2f27e28225 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
- nx affected --target=e2e --base=c0a0f1691373996f1b76622143c5646168ef1eb3 --head=392e191d84eaf0267b4639b98dd56b2f27e28225 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
- nx affected --target=lint --base=c0a0f1691373996f1b76622143c5646168ef1eb3 --head=392e191d84eaf0267b4639b98dd56b2f27e28225 --parallel=3
- nx affected --target=test --base=c0a0f1691373996f1b76622143c5646168ef1eb3 --head=392e191d84eaf0267b4639b98dd56b2f27e28225 --parallel=1
- nx build typedoc-theme
- nx-cloud record -- yarn check-commit
- nx-cloud record -- yarn check-imports
- nx-cloud record -- yarn depcheck
- nx-cloud record -- yarn documentation
- nx-cloud record -- yarn nx format:check --base=c0a0f1691373996f1b76622143c5646168ef1eb3 --head=392e191d84eaf0267b4639b98dd56b2f27e28225
- nx-cloud record -- yarn nx workspace-lint
Sent with 💌 from NxCloud.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated | 
|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | Jun 6, 2022 at 2:32PM (UTC) | 
Hi @mckramer thank you for the PR, can you rebase the PR and fix the conflict?
Hey @mckramer! This PR has been sitting around for a bit. I have some concerns with using '[inherit]' as a version token inside the project's package.json, as if a workspace is also using package manager's workspace functionality (e.g. yarn workspaces), it would cause errors on installation.
As such, I'm going to go ahead and close this PR. Lets talk over potential solutions in an issue, and then after we agree with how to move forward a community member or team member can open a new PR.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.