react-native-image-tools icon indicating copy to clipboard operation
react-native-image-tools copied to clipboard

Option to edit output photo name

Open edencakir opened this issue 8 years ago • 9 comments

Saved photos are always saved with a prefix 'rnimagetools', is there a way to avoid that?

edencakir avatar Jul 15 '17 13:07 edencakir

@edencakir Are you able to save the images? For me, as soon as I click the done button the app crashes on IOS. Could you share me your implementation?

srameshr avatar Jul 15 '17 14:07 srameshr

Ive only implemented for Android.

edencakir avatar Jul 19 '17 07:07 edencakir

@srameshr can you post the stacktrace of the error?

edencakir avatar Jul 19 '17 07:07 edencakir

@edencakir I fixed it. It was permissions issue. BTW whats the increase in file size when u download the SDK? What will be the file size when you proguard compress it?

srameshr avatar Jul 19 '17 13:07 srameshr

Nope, it's not a concern for my project. SDK is standard and can't do anything about it - unrelated to this repo.

edencakir avatar Jul 19 '17 14:07 edencakir

@edencakir I understand that. I just want to know whats the size the editor sdk adds to ur app.

srameshr avatar Jul 19 '17 16:07 srameshr

APK size is 17 MB, I'm not sure how much of it is from SDK.

edencakir avatar Jul 19 '17 18:07 edencakir

Np plans to pass in an option for naming the photos. it easy enough to change them using rn-fetch-blob. Or submit a PR if you desperately want the feature.

npomfret avatar Jul 23 '17 17:07 npomfret

@npomfret Its not immediate. Passing tools option to the editor will be an awesome addition.

srameshr avatar Jul 24 '17 07:07 srameshr