marky-markdown icon indicating copy to clipboard operation
marky-markdown copied to clipboard

Published 20 hours ago • verified publisher icon npm

review badge processing

Open ashleygwilliams opened this issue 9 years ago • 3 comments

from a quick read there are few things that concern me about how we process badges:

  • we add classes that GitHub doesn't add
  • we statically list a set of origins that is definitely not complete and we haven't updated in a while

given the product direction of parity with GitHub, and a desire for improved performance, i'd like to revisit this code and remove unnecessary processing. thoughts?

ashleygwilliams avatar Oct 05 '16 17:10 ashleygwilliams

relevant code:

  • impl https://github.com/npm/marky-markdown/blob/0302f9f515248a86153f67ba26d48729a87ff45e/lib/badges.js
  • tests https://github.com/npm/marky-markdown/blob/0302f9f515248a86153f67ba26d48729a87ff45e/test/badges.js

ashleygwilliams avatar Oct 05 '16 17:10 ashleygwilliams

Maybe of use: https://github.com/wooorm/is-badge (can also be used in GH-251).

wooorm avatar Oct 05 '16 19:10 wooorm

oh awesome, thanks @wooorm that looks perfect 👍

revin avatar Oct 10 '16 20:10 revin