notify icon indicating copy to clipboard operation
notify copied to clipboard

Published 20 hours ago • verified publisher icon notify-rs

Consider hiding fields in Event

Open erickt opened this issue 4 years ago • 1 comments

As part of developing #307, I realized it might be worth hiding the public fields in Event as part of 5.0.0. This would allow the underlying object to be extended with new attributes without breaking existing clients. I have a proof-of-concept of this change in https://github.com/erickt/notify/tree/hide-fields that's built upon #307 that I can push up after we address #306.

erickt avatar May 10 '21 23:05 erickt

I've got no real stakes in this, we've had no problems with them being public so far. Also your current implementation adds an additional .clone - though its probably irrelevant. So I'm ok with merging it.

0xpr03 avatar May 11 '21 00:05 0xpr03