lein-garden icon indicating copy to clipboard operation
lein-garden copied to clipboard

Add 'id' default to 'validate-builds'

Open ccfontes opened this issue 10 years ago • 5 comments

ccfontes avatar Nov 27 '14 21:11 ccfontes

Solves #27

ccfontes avatar Nov 27 '14 21:11 ccfontes

Something needs to be fixed?

ccfontes avatar Dec 20 '14 18:12 ccfontes

@ccfontes Sorry for the delay. I haven't had the time to review/merge/release this yet. I've been really busy with work and family. Chances are I won't be able to do much until the new year. My apologies!

noprompt avatar Dec 22 '14 06:12 noprompt

bump

ccfontes avatar Feb 10 '15 02:02 ccfontes

@ccfontes Sorry for such a long pause. I don't see how this solves #27. This is about :ids and #27 was about :source-paths. Also I don't think defaulting id to "undefined" is the solution here. The :id field should be required just as :source-paths is. How about adding (not (string? id)) to the top of the cond?

noprompt avatar May 10 '15 04:05 noprompt