resources icon indicating copy to clipboard operation
resources copied to clipboard

Feature request: Multiple CPU temp sensors (or don't use Tctl)

Open DaveKram opened this issue 1 year ago • 2 comments

First off, great application!

Something to consider, is that with some CPUs, more than one temperature sensor is reported under sysfs hwmon.

A quick look at the code shows you using just temp1_input to display. temp1_input is Tctl and used for fan control, and not really the actual useful CPU temperatures Kernel driver k10temp Description about multiple sensors.

For instance, doing a: watch -n1 sensors on my machine (I have an AMD 7900x3D), I have:

Screenshot from 2023-12-30 11-12-49

My suggestion is to display all available temp_input files via sysfs on the GUI, or show something other than Tctl. I don't believe I saw another issue around this, so apologies if it already exists.

Again, just a suggestion and something I noticed.

DaveKram avatar Dec 30 '23 16:12 DaveKram

Hi, thanks for the issue, I'm glad you like Resources! :) I didn't know that about k10temp, I'll look into it. I'd prefer a single value for the temperature though as I prefer Resources to be simple to use. I'd go for Tdie (temp2_input) then, but your screenshot doesn't seem to have that :/

nokyan avatar Dec 30 '23 20:12 nokyan

I am the type of person that likes to see what's all available to me, and be able to hide/toggle behavior if I don't want to see things.

My personal preference to show all the temp sensors (since you have the GUI labeled Sensors anyway) - and like I said, maybe a way to toggle those on/off visible (if you don't want to show multiple sensors). Another option is to have a preference option in the settings window for those with multiple temp sensors.

Or you don't have to do any of the above, since it's your app :)

And yes, I don't have any temp2_input in sysfs hwmon for my AMD cpu. Just temp1_input, temp3_input, temp4_input - as is described in the k10 driver description.

DaveKram avatar Jan 03 '24 21:01 DaveKram