node-vault

node-vault copied to clipboard

1. Maintained fork of Request
2. Easiest to switch to
3. No support for request-promise-native so we had to build our own

Need to discuss how to best handle what happens when request-promise already provided and how best to Unit Test

    if (config['request-promise'] != null) {
      return rpObject(options);
    }

PS had to update from Istanbul to NYC. Any coverage testing was breaking on my Windows machine without it

@aviadhahami @kr1sp1n could you look into this?

hey :) overall looks ok, I just can't do anything lib-wise until ownership transfer is complete

https://github.com/kr1sp1n/node-vault/issues/150#issuecomment-1015688481

@aviadhahami I wanted to ask you and @kr1sp1n about how to handle it when

1. Request Promise is already provided
2. Do we create a new Request-Library option to pass the Request Library?
3. How to unit test the Postman Request library

    if (config['request-promise'] != null) {
      return rpObject(options);
    }

Currently am using this

tbh I didn't dive into this yet. Will do once ownership is transferred, until then we can't do anything 🤷‍♂️

edit: on quick glance this != null may be the correct solution

got the permissions (almost all what I need), trying to get this in asap

@pratikpc do you mind updating the base for this PR? :)

Closing in favor of https://github.com/nodevault/node-vault/pull/231