node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Published 20 hours ago • verified publisher icon nodevault

unwrap was missing in type defintion

Open me23 opened this issue 5 years ago • 4 comments

me23 avatar Jun 22 '20 10:06 me23

Codecov Report

Merging #158 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       146           
  Branches        37        37           
=========================================
  Hits           146       146

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 496657b...779a832. Read the comment docs.

codecov[bot] avatar Jun 22 '20 10:06 codecov[bot]

@me23 can you add a test for this?

aviadhahami avatar Nov 10 '22 17:11 aviadhahami

Hi, there is a test for unwrap already. The only thing i added was the type-definition for the unwrap, so that typescript won't complain about unknown method unwrap... So i don't think we need another test?! bye me23

me23 avatar May 11 '23 21:05 me23

@me23 there are plenty of changes in your diff, could u please rebase and check that you only pr the relevant change?

aviadhahami avatar May 13 '23 21:05 aviadhahami